commit | 9dc8c43529b23104501967724f6df75c63cab3d3 | [log] [tgz] |
---|---|---|
author | Tom Bergan <tombergan@google.com> | Mon Oct 09 19:18:50 2023 +0000 |
committer | Tom Bergan <tombergan@google.com> | Mon Oct 09 20:40:06 2023 +0000 |
tree | e497b2f785443b62b4b2d661995bb1d1322a8f0f | |
parent | e645823b68ab8318f1bbf537daa48e9d488e680f [diff] |
checkstyle: add junitparams to ImportOrder Checkstyle and google-java-format currently disagree on the order of junitparams.* imports. This change enforces alphabetical ordering of third-party imports (such as junitparams) in accordance with: https://source.android.com/docs/setup/contribute/code-style#order-import-statements Test: manually verified that `repo upload .` passes checkstyle with the correct import order Change-Id: I03e1a9d75f9f675916f14bbc1b1ba35dc325a195
Checkstyle is used by developers to validate Java code style and formatting, and can be run as part of the pre-upload hooks.
It can be invoked in two ways.
checkstyle.py -f FILE [FILE ...]
checkstyle.py
A development tool to help programmers write Java code that adheres to a coding standard.
Git-lint is a tool to run lint checks on only files changed in the latest commit.
To run checkstyle as part of the pre-upload hooks, add the following line to your PREUPLOAD.cfg
:
checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}
Note that checkstyle does not always agree with clang-format, and so it's best to only have one enabled for Java.
In .clang-format
add the following to disable format checking and correcting for Java:
--- Language: Java DisableFormat: true SortIncludes: false ---
In some versions of clang-format, DisableFormat
doesn't stop the sorting of includes. So to fully disable clang-format from doing anything for Java files, both options are needed.