commit | 4375d671a2e37aa255dbaa0348af275f317f9c65 | [log] [tgz] |
---|---|---|
author | Kirit <kirit@google.com> | Fri Jun 16 19:52:50 2023 +0000 |
committer | Kirit <kirit@google.com> | Fri Jun 23 19:30:25 2023 +0000 |
tree | 1246654cd592789ab9e4213d2d650e7c7edbfe3e | |
parent | 54f4a8555ba22635cc590ee30fe4951247b40325 [diff] |
checkstyle: add io to ImportOrder Checkstyle and google-java-format currently disagree on the order of io. imports. This change enforces alphabetical ordering in accordance with https://source.android.com/docs/setup/contribute/code-style#order-import-statements Test: manual testing that `repo upload .` passes checks with the correct io import order. Fixes: b/287664151 Merged-In: Iae54e301ea5a96711896c24632231a2c776606df Change-Id: Idbcf201d007f5d18763d1516ceefed276d7fd5cc
Checkstyle is used by developers to validate Java code style and formatting, and can be run as part of the pre-upload hooks.
It can be invoked in two ways.
checkstyle.py -f FILE [FILE ...]
checkstyle.py
A development tool to help programmers write Java code that adheres to a coding standard.
Git-lint is a tool to run lint checks on only files changed in the latest commit.
To run checkstyle as part of the pre-upload hooks, add the following line to your PREUPLOAD.cfg
:
checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}
Note that checkstyle does not always agree with clang-format, and so it's best to only have one enabled for Java.
In .clang-format
add the following to disable format checking and correcting for Java:
--- Language: Java DisableFormat: true SortIncludes: false ---
In some versions of clang-format, DisableFormat
doesn't stop the sorting of includes. So to fully disable clang-format from doing anything for Java files, both options are needed.