commit | 2511a1b15a266487d115262b3de72d34ed8cca8c | [log] [tgz] |
---|---|---|
author | Pat Manning <patmanning@google.com> | Tue Sep 12 14:12:48 2023 +0000 |
committer | Sorin Basca <sorinbasca@google.com> | Wed Sep 13 07:45:04 2023 +0000 |
tree | 808c772560b3760dac4dace74e0517ecc01ec196 | |
parent | 5b129846c545ad22e7bd72f975902526c4864d9b [diff] |
Fix checkstyle to include spacing between static imports. When upgrading checkstyle v7.4 to v10.12, new properties were added such as staticGroups (v8.12) and separatedStaticGroups (v8.12) which are set to default false. Bug: 291925520 Fixes: 299677267 Change-Id: I1350ab5448f1d05b40a8a4a791e3e7227364c883 Test: repo upload
Checkstyle is used by developers to validate Java code style and formatting, and can be run as part of the pre-upload hooks.
It can be invoked in two ways.
checkstyle.py -f FILE [FILE ...]
checkstyle.py
A development tool to help programmers write Java code that adheres to a coding standard.
Git-lint is a tool to run lint checks on only files changed in the latest commit.
To run checkstyle as part of the pre-upload hooks, add the following line to your PREUPLOAD.cfg
:
checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}
Note that checkstyle does not always agree with clang-format, and so it's best to only have one enabled for Java.
In .clang-format
add the following to disable format checking and correcting for Java:
--- Language: Java DisableFormat: true SortIncludes: false ---
In some versions of clang-format, DisableFormat
doesn't stop the sorting of includes. So to fully disable clang-format from doing anything for Java files, both options are needed.