commit | 06cc0c6dc18e1e45be370a9491bb4f57042176f0 | [log] [tgz] |
---|---|---|
author | Luca Stefani <luca.stefani.ge1@gmail.com> | Thu Aug 27 10:48:35 2020 +0200 |
committer | Naomi Musgrave <nmusgrave@google.com> | Mon Jan 30 20:44:16 2023 +0000 |
tree | d23c11abff6ec562d0b6bf17274f239af51c3b49 | |
parent | adef809ab8b15022a6c7256e472a88c9901dc64d [diff] |
gitlint: Fix string concatenation * "commit" is an encoded string, so bytes, hence convert the str to append to bytes as well aosp commit https://android-review.googlesource.com/c/platform/prebuilts/checkstyle/+/1412928 Bug: 196407401 Fix: 233023373 Test: repo upload Merged-In: Iaa0b2e047a7f859831b203533c96071d819ef3d1 Change-Id: Iaa0b2e047a7f859831b203533c96071d819ef3d1 (cherry picked from commit 9f2a68c00b6169e18eafc5a93bc0a677bd247441)
Checkstyle is used by developers to validate Java code style and formatting, and can be run as part of the pre-upload hooks.
It can be invoked in two ways.
checkstyle.py -f FILE [FILE ...]
checkstyle.py
A development tool to help programmers write Java code that adheres to a coding standard.
Git-lint is a tool to run lint checks on only files changed in the latest commit.
To run checkstyle as part of the pre-upload hooks, add the following line to your PREUPLOAD.cfg
:
checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}
Note that checkstyle does not always agree with clang-format, and so it's best to only have one enabled for Java.
In .clang-format
add the following to disable format checking and correcting for Java:
--- Language: Java DisableFormat: true SortIncludes: false ---
In some versions of clang-format, DisableFormat
doesn't stop the sorting of includes. So to fully disable clang-format from doing anything for Java files, both options are needed.