| commit | 61074474aaa4ed8c663fec2e98764653db00300d | [log] [tgz] |
|---|---|---|
| author | Eric Lok <lokeric@google.com> | Mon Feb 26 08:53:55 2024 +0000 |
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 28 01:08:53 2024 +0000 |
| tree | 1834a0f990609cad0b19594e962be484f86aea42 | |
| parent | c75f0ff3942b3fd2feb8bb4bcc64d3e47149ece8 [diff] |
Dedupe addition of crash-diagnostics-dir
For chromeos-chrome builds, we need to remove any unnecessary
{PVR} like info from the build cmd in order for cache hits across
builds.
chromeos-chrome already defines "crash_diagnostics-dir" in such a
manner, but compiler-wrapper adds a duplicate definition of this same
flag but with {PVR} like info.
The fix here is to update compiler-wrapper so that it does not add
"crash-diagnostics-dir" if it is already defined.
BUG=b:326847828
TEST=go test -vet=all (and added more tests)
Change-Id: I81c4dbb29241e85cf78659f35ac9dd93999b6b01
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5321366
Tested-by: Eric Lok <lokeric@google.com>
Commit-Queue: Eric Lok <lokeric@google.com>
Auto-Submit: Eric Lok <lokeric@google.com>
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org>
Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
toolchain-utilsVarious utilities used by the ChromeOS toolchain team.
To run Python scripts in this directory, first run:
export PYTHONPATH=$(readlink -f .):$PYTHONPATH
from this directory.
Then you can run any script.
To get help on any script, type in python <script> --help, or refer to the header of the script for more information.