| commit | b12032b6d9865361be4741535e2059c9d1af6414 | [log] [tgz] |
|---|---|---|
| author | Matthias Maennich <maennich@google.com> | Wed Jun 30 15:38:32 2021 +0100 |
| committer | Matthias Maennich <maennich@google.com> | Wed Jun 30 17:27:12 2021 +0100 |
| tree | 549e41ae0f555ad84b46e14eeff263f46a55c722 | |
| parent | 419f4d4d453516c6b33f68b04a9157c6b832f0bd [diff] |
strutil: fix delimiters for skipping whitespaces
Commit a8ca5d35306a ("strutil: replace SSE4 specialization with libc
call") switched an SSE4 optimization of SkipUntil to using strpbrk. By
not matching the full ranges (i.e. not all control characters between
\x09 and \x0d), this lead to wrong results when processing real-world
Makefiles containing line continuation statements. Fix this by filling
up the set of delimiters.
Reported-by: Dan Willemsen <dwillemsen@google.com>
Fixes: a8ca5d35306a ("strutil: replace SSE4 specialization with libc call")
Signed-off-by: Matthias Maennich <maennich@google.com>
kati is an experimental GNU make clone. The main goal of this tool is to speed-up incremental build of Android.
Currently, kati does not offer a faster build by itself. It instead converts your Makefile to a ninja file.
Building:
$ make ckati
The above command produces a ckati binary in the project root.
Testing (best ran in a Ubuntu 20.04 environment):
$ make test $ go test --ckati $ go test --ckati --ninja $ go test --ckati --ninja --all
The above commands run all cKati and Ninja tests in the testcases/ directory.
Alternatively, you can also run the tests in a Docker container in a prepared test enviroment:
$ docker build -t kati-test . && docker run kati-test
If you are working on a machine that does not provide make in the same version as kati is currently compatible with, you might want to download a prebuilt version instead. For example to use the prebuilt version of Ubuntu 20.04 LTS:
$ mkdir tmp/ && cd tmp/ $ wget http://mirrors.kernel.org/ubuntu/pool/main/m/make-dfsg/make_4.2.1-1.2_amd64.deb $ ar xv make_4.2.1-1.2_amd64.deb $ tar xf data.tar.xz $ cd .. $ PATH=$(pwd)/tmp/usr/bin/:$PATH make test
For Android-N+, ckati and ninja is used automatically. There is a prebuilt checked in under prebuilts/build-tools that is used.
All Android's build commands (m, mmm, mmma, etc.) should just work.