commit | 19206f23579797d1ef6bc48549eb0b3ce91fc7f3 | [log] [tgz] |
---|---|---|
author | Neil Fuller <nfuller@google.com> | Tue Jan 24 17:35:16 2023 +0000 |
committer | Neil Fuller <nfuller@google.com> | Tue Jan 24 17:35:16 2023 +0000 |
tree | f6f512d88043f81a689e801b14700cadbc4b3ff7 | |
parent | 75114337bf4d29b85a39567a9f335c7198655a95 [diff] |
Add /robotests/ to the list of test patterns Robolectric tests were not being exempted, leading to requirements like javadoc being required on all public methods. Test: Uploaded a change without javadoc successfully that previously failed Bug: None Change-Id: If350578a5a612001d879019865b7b630a19cfebd
Checkstyle is used by developers to validate Java code style and formatting, and can be run as part of the pre-upload hooks.
It can be invoked in two ways.
checkstyle.py -f FILE [FILE ...]
checkstyle.py
A development tool to help programmers write Java code that adheres to a coding standard.
Git-lint is a tool to run lint checks on only files changed in the latest commit.
To run checkstyle as part of the pre-upload hooks, add the following line to your PREUPLOAD.cfg
:
checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}
Note that checkstyle does not always agree with clang-format, and so it's best to only have one enabled for Java.
In .clang-format
add the following to disable format checking and correcting for Java:
--- Language: Java DisableFormat: true SortIncludes: false ---
In some versions of clang-format, DisableFormat
doesn't stop the sorting of includes. So to fully disable clang-format from doing anything for Java files, both options are needed.