tree 5376f8a78c74dc13d6867e808b3271dcd2964320
parent 7a723127024fcbd803abd07500fb736f37493187
author newt@chromium.org <newt@chromium.org> 1414772687 +0000
committer newt@chromium.org <newt@chromium.org> 1414772687 +0000

Apply whitelist file to structure elements.

Resources specified with structure elements were being included in
.pak and .h files even if they were not included in a specified
whitelist file.

The .pak file issue is fixed in build.py by including structure nodes
in the collection of node types that are checked against the whitelist.
This seems to be an oversight as the code has a comment like "Apply
the same trick that data_pack.py uses" but the corresponding code in
data_pack.py was updated to include structure noded in [1]. This method
that contained this code is no longer in data_pack.py.

The .h file issue is fixed in rc_header.py by treating structure nodes
in the same manner as message nodes (i.e. only output them if they're
active). The correct fix seems to be to set output_all_resource_defines
to true in all the .grd files, but until then a structure element should
not generate an entry in a header file if it's not in the whitelist.

https://chromiumcodereview.appspot.com/10386189/diff/29002/grit/format/data_pack.py

BUG=None
R=joaodasilva@chromium.org, newt@chromium.org

Review URL: https://codereview.chromium.org/669763002

Patch from Lane LiaBraaten <lliabraa@chromium.org>.

git-svn-id: http://grit-i18n.googlecode.com/svn/trunk@179 7262f16d-afe8-6277-6482-052fa10e57b1